/*
    Schritt 1: eine LED Blink Klasse
    https://forum.arduino.cc/t/c-und-klassen-objekte-komisches-verhalten/1317182/9
    
    2024-11-01 by noiasca - based on variable naming of Skee0r1

    code not in thread
*/

#include "Led.h"

//LedController leds;

Led leds[] {11, 10, 9, 8};

void setup() {
  Serial.begin(115200);
  Serial.println("Startup");

  for (auto &l : leds) {
    l.begin();          // setup HW
    l.activate();       // activate blinking
  }
  // now set some individual values
  leds[0].setInterval(3000);
  leds[1].setInterval(2000);
  leds[2].setInterval(1000);
  leds[1].setShineDuration(500);
  leds[3].setShineDuration(1000);
}

void loop() {
  for (auto &l : leds) l.check();
}


sketch.ino

diagram.json

/*
#ifndef LedController_h
#define LedController_h
#include <Arduino.h>
#include "Led.h"
#include "Timer.h"

class LedController {
public:
  LedController();
  void init();
  void check();
  void showError();
  void showOk();
  void showWarning();
  
  
private:
  Led _red;
  Led _blue;
  Led _yellow;
  Led _green;
};


#endif
*/

LedController.h

/*
#include <Arduino.h>
#include "LedController.h"
#include "Led.h"
#include "Timer.h"

LedController::LedController(){}

void LedController::init() {
  _red=Led(11);
  _blue=Led(10);
  _yellow=Led(9);
  _green=Led(8);
}

void LedController::showWarning() {
  Serial.println("Activate yellow");
  _yellow.activate();
}

void LedController::showError() {
  _red.activate();
}

void LedController::showOk() {
  _green.activate();
}

void LedController::check() {
  Serial.print("Current time: ");
  Serial.println(Timer::getTime(),DEC);

  Serial.println("Check red");
  _red.check();

  Serial.println("Check blue");
  _blue.check();

  Serial.println("Check yellow");
  _yellow.check();

  Serial.println("Check green");
  _green.check();
}
*/



LedController.cpp

/*
#ifndef Timer_h
#define Timer_h
#include <Arduino.h>

class Timer {
public:
  static void addOffset(unsigned long);
  static void init();
  static unsigned long getTime();
private:
  inline static unsigned long _offset;
};


#endif
*/

Timer.h

/*
#include "Arduino.h"
#include "Timer.h"

unsigned long _offset=0;

void Timer::addOffset(unsigned long _offset) {
  Timer::_offset+=_offset;
  //Serial.println("new offset:");
  //Serial.println(Timer::_offset, DEC);
}

unsigned long Timer::getTime() {
  return millis()+Timer::_offset;
}
*/

Timer.cpp

#pragma once
#include <Arduino.h>

class Led {
    public:
    //Led();                  // LED ohne pin soll es nicht geben
    Led(uint8_t pin);
    void activate();
    void begin();
    void deactivate();
    void check(uint32_t currentMillis = millis());
    void setInterval(uint32_t value);
    void setShineDuration(uint32_t value);
  private:
    const uint8_t pin;            // the GPIO
    boolean isActive = false;     // ob diese LED grundsätzlich grad aktiv ist, also blinken soll (_active)
    boolean isOn = false;         // und ob die LED grad an/aus ist (_isOn)
    uint32_t interval = 5000;     // off phase
    uint32_t shineDuration = 50;  // on phase
    void turnOn();
    void turnOff();
    uint32_t previousMillis = 0;  // last change
};


Led.h

#include "Print.h"
#include <Arduino.h>
#include "Led.h"
//#include "Timer.h"

Led::Led(uint8_t pin) : pin(pin) {}

void Led::begin() {
  pinMode(pin, OUTPUT);  //initialize the digital pin as an output
  digitalWrite(pin, LOW);
  Serial.print(pin);
  Serial.println(" Init");
}

void Led::activate() {
  if (isActive) {
    return;
  }
  isActive = true;
  turnOn();
}

void Led::deactivate() {
  if (!isActive) {
    return;
  }
  isActive = false;
  turnOff();
}

void Led::setInterval(uint32_t value) {
  interval = value;
}

void Led::setShineDuration(uint32_t value) {
  shineDuration = value;
}

void Led::turnOn() {
  digitalWrite(pin, HIGH);
  //previousMillis = millis();   // optional - aber imho nicht passend in dieser Funktion
  isOn = true;
  Serial.print(pin); Serial.println(" Toggle to OFF ");
}

void Led::turnOff() {
  digitalWrite(pin, LOW);
  //previousMillis = millis();   // optional - aber imho nicht passend in dieser Funktion
  isOn = false;
  Serial.print(pin); Serial.println(" Toggle to ON ");
}

void Led::check(uint32_t currentMillis) {
  if (!isActive) {
    return;  // return early
  }
  if (isOn && currentMillis - previousMillis > shineDuration ) {
    previousMillis = currentMillis;
    turnOff();
    return;
  }
  if (!isOn && currentMillis - previousMillis > interval ) {
    previousMillis = currentMillis;
    turnOn();
    return;
  }
}
